Retain atomic class for bare atomic inputs on collection - #68
Open
LJ-Jenkins wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
I was playing around with retaining class without changing too much code, but it ended up opening a bit of a can of worms in my head around which objects should be unlisted vs which shouldn't, which attributes should be preserved vs dropped, and where the line is between "destructuring" and "restructuring".
As I see it, there are three possible approaches here:
I think all three approaches have their own pros and cons but I imagine 3 would go against the longstanding zeallot behaviour. This PR is an implementation of option 2, but I'm happy to leave it to you to decide which direction makes the most sense overall.
(Also, note that this was branched off PR #66.)